This repository has been archived by the owner on Nov 11, 2022. It is now read-only.
forked from filecoin-project/ref-fvm
-
Notifications
You must be signed in to change notification settings - Fork 1
Rebase master and fix actor type IDs for HC #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue-523 propagate all gas outputs in ApplyRet
Instead of looking up the memory export on every syscall, resolve it when we construct the invocation container. fixes filecoin-project#510
…-chrono fix: remove unused chrono dep
* exec gas: apply only on non-structural instructions. * pricelist: add new gas fees. * gas: fully switch to milligas as canonical unit. * price list: update gas cost formulae. * price list: vertical spacing. * kernel: apply extern gas. * syscalls: charge for gas; small refactors. * remove Kernel#charge_milligas(). Canonical unit is now milligas everywhere. * fix tests. * fix param. * clippy. * add comment. * fix gas instrumentation. * rename GasTracker#{charge_gas=>apply_charge} to disambiguate. * add Gas and Milligas unit types to disambiguate. * convert public gas charges to milligas. * inclusion cost: adapt to milligas. * charge_gas: move conversion to milligas to syscall handler. * {to_milligas=>static_milligas}; make private. * clippy. * price list: remove compute_gas_multiplier (unused). * polish comment. * use saturation arithmetics for mem costs. * price list: use Milligas type for cost fields. * rename Kernel#charge_{=>milli}gas. * add extern cost in syscall pricing formulae. * charge for syscall gas at the right place.
Error if one tries to decode a bitfield that is too large.
This adds a new gas type to avoid things like: 1. Multiplying gas by gas (not possible now). 2. Swapping gas/milligas. 3. Not using saturating arithmetic. This change also caught and fixed a bug where the "extra" consensus fault fee from lotus was being charged as milligas, not gas. Motivation: the previous commit that fixed a bug in window post cost scaling.
…ce-list-snafu Strongly typed gas units, and fix two related bugs
* wip better stack limits * stack overflow integration test * lower wasm stack / call depth limits * use a threadpool with 64MiB stacks for execution * Improve out-of-stack integration test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.